adding smallscale changes to graham implementation, fft, and thomas. #113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I really like your update for Graham Scan, thumbs up! |
|
It was gathros's idea. For some reason, I didn't think of using |
jiegillet
added
Implementation Edit
|
There are many ways of calculating angles, I also used atan2 (although I used 2, I see now that I could simplify it) |
jiegillet
approved these changes
May 15, 2018
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are a few quick updates to the implementation of graham scan. I also slightly modified the spacing in the fft algorithm and removed a comment that shouldn'e be there and fixed some stuff with the
thomas.mdfile.As a note: we indicated that the readme could use some work and should be split so it's not on algorithm-archive.org anymore. The reason we have the readme as the first page is in part because of how gitbook worked when we were using it. Since we are no longer on gitbook, this shouldn't be an issue anymore.